[release-1.10] chore: bump backstage/errors to 1.3.0#5039
Draft
04kash wants to merge 2 commits into
Draft
Conversation
Signed-off-by: Kashish Mittal <kmittal@redhat.com>
|
Skipping CI for Draft Pull Request. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.10 #5039 +/- ##
=================================================
+ Coverage 41.03% 69.24% +28.21%
=================================================
Files 121 123 +2
Lines 2220 4920 +2700
Branches 563 563
=================================================
+ Hits 911 3407 +2496
- Misses 1303 1508 +205
+ Partials 6 5 -1
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
RHDH 1.10 is on Backstage 1.49.4, so the RHDH backend provides @backstage/errors 1.2.7. We were pulling in @backstage/plugin-techdocs-node 1.14.5, which calls toError (added in errors 1.3.0). techdocs-node is bundled into the dynamic plugin, but @backstage/errors is a peerDep — it's not bundled, the RHDH backend provides it at runtime. So techdocs-node's ^1.3.0 declaration only affects the build workspace; it doesn't upgrade what the backend actually loads.
1.14.5 came in through global-header's caret on @backstage/plugin-search-backend-module-techdocs. Yarn resolved that to 0.4.13, which depends on techdocs-node ^1.14.5, and deduped it with the techdocs wrapper's 0.4.12 pin. techdocs-node 1.14.5 did bump its @backstage/errors minimum correctly (backstage/backstage#33720); the problem is the RHDH backend still serves 1.2.7.
This PR bumps @backstage/errors to 1.3.0 to pull in the
toErrorfunction. (withyarn up @backstage/errors@1.3.0andyarn dedupe @backstage/errors)Alternative is to pin
techdocs-node: #4962Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer